Fix an assertion failure in SILMem2Reg. #6695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ASI->eraseFromParent() call after removeSingleBlockAllocation(ASI) will assert if there are any remaining uses of the allocation ASI. This can happen if there are any dead instructions for struct or tuple address projections, since removeSingleBlockAllocation only removes the instructions that are actually used by loads and stores. The existing stdlib/subString.swift test exposes this issue when running check-swift-optimize. rdar://problem/28671838
|
@swift-ci please smoke test |
|
@eeckstein Can you please review this? |
|
A reduced test case would be nice. |
|
LGTM! |
|
On second thought, since this fixes a bug, we can merge it as-is, as long as @bob-wilson adds that new testcase one day :-) |
|
Thanks. I'm still hoping to get that testcase this week. If I can't get it done by Friday, I'll go ahead without it. |
|
It's Friday! ominous music plays |
|
Yeah, I spent all week doing meetings and stuff. I'm looking at the test case now, but I'll merge the fix separately. |
|
Here's a test case: #6987 (Writing the SIL by hand was far easier than I expected and I can't believe I spent so much time trying to reduce a test case from the original input. Sorry it took so long.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ASI->eraseFromParent() call after removeSingleBlockAllocation(ASI)
will assert if there are any remaining uses of the allocation ASI. This can
happen if there are any dead instructions for struct or tuple address
projections, since removeSingleBlockAllocation only removes the instructions
that are actually used by loads and stores. The existing stdlib/subString.swift
test exposes this issue when running check-swift-optimize.
rdar://problem/28671838