[move-only] Emit an error if we /ever/ partially consume a noncopyable type. #66952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gottesmm
requested review from
hborla,
slavapestov,
xedin and
tshortli
as code owners
|
@swift-ci test |
|
@swift-ci test macOS platform |
1 similar comment
|
@swift-ci test macOS platform |
jckarter
reviewed
Jun 27, 2023
jckarter
approved these changes
Jun 27, 2023
…ccessing fields of lets. In the next commit, I am modifying the move only checker to ensure that we always error when partially invalidating. While doing this I discovered that these copies were getting in the way of emitting good diagnostics in that case.
…e type. The reason why I am doing this is that this was not part of the original evolution proposal (it was called an extension) and after some discussion it was realized that partial consumption would benefit from discussion on the forums. rdar://111353459
gottesmm
force-pushed
the
pr-87fcc78991b465d8a15454dc76b66d6f347ddff0
branch
from
05e54a3 to
3dde9df
Compare
|
@swift-ci test |
|
@swift-ci test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason why I am doing this is that this was not part of the original
evolution proposal (it was called an extension) and after some discussion it was
realized that partial consumption would benefit from discussion on the forums.
rdar://111353459
I also needed to add a small optimization to eliminate some iterated copies that are inserted by SILGen since otherwise the diagnostic gets borked. It works by just walking def->uses and is very conservative by: 1. Only pattern matching a very exact sequence. 2. Making sure that all visited iterative copies are in the same block and do not have any side effects in the sequence of instructions.