Inherit -strict-implicit-module-context when build sub swiftinterface #66980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ub swiftinterface
|
@Fushj89 could you please first file a PR with this change targeting |
|
@swift-ci test |
artemcm
approved these changes
Jul 5, 2023
|
@artemcm I edit the PR description format. The PR is waiting for another approve, can you help find other reviewer to review it. |
|
@DougGregor Can you help review the PR |
nkcsgexi
reviewed
Jul 18, 2023
| @@ -1830,6 +1832,10 @@ InterfaceSubContextDelegateImpl::runInSubCompilerInstance(StringRef moduleName, | |||
| // invocation. | |||
| CompilerInvocation subInvocation = genericSubInvocation; | |||
|
|
|||
| // save `StrictImplicitModuleContext` | |||
| bool StrictImplicitModuleContext = | |||
| subInvocation.getFrontendOptions().StrictImplicitModuleContext; | |||
There was a problem hiding this comment.
Why do we need to save and restore StrictImplicitModuleContext here? It stands out from the rest of frontend options.
|
We are past taking changes of this nature in 5.9 for non-critical fixes, and are focusing on upcoming releases. This change made it to 5.10 so that will be the first release containing this change. Thank you @Fushj89! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #67009
strict-implicit-module-contextflag which causes sub invocation build clang module in the swiftinterface failed.-strict-implicit-module-contextto swift-frontend