[5.9][ConstraintSystem] Fix a couple of issues related to generic specialization #67026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zation - Teach specialization constraint to look through non-generic typealiases - Detect and diagnose attempts to specialize non-generic types/aliases - Detect and diagnose attempts to specialize types with invalid number of arguments (cherry picked from commit 42f80fb) (cherry picked from commit cbaf558) (cherry picked from commit ab2f47b) (cherry picked from commit 40169c7) (cherry picked from commit 2bbda09) (cherry picked from commit cd057bb) (cherry picked from commit be4df5a) (cherry picked from commit b9b21fc) (cherry picked from commit de729e2)
|
@swift-ci please test |
hborla
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #66971
Explanation:
Scope: Expressions with generic specialization of typealiases that are shadowed by macros
Main Branch PR: [ConstraintSystem] Fix a couple of issues related to generic specialization #66971
Risk: Low
Reviewed By: @hborla @slavapestov
Testing: Added regression test-cases to the suite.
Resolves: rdar://111239949
(cherry picked from commit 42f80fb)
(cherry picked from commit cbaf558)
(cherry picked from commit ab2f47b)
(cherry picked from commit 40169c7)
(cherry picked from commit 2bbda09)
(cherry picked from commit cd057bb)
(cherry picked from commit be4df5a)
(cherry picked from commit b9b21fc)
(cherry picked from commit de729e2)