Make the @Observable macro class only
#67033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These conformances enable automatic Codable synthesis for Observable types, and smooth the runway for structs being supported by the Observable macro in the future.
This removes the ability for the Observable macro to apply to structs, and adds diagnostic tests for the three disallowed declaration kinds.
|
@swift-ci Please test |
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
|
@swift-ci Please test macOS platform (unrelated failure last time) |
phausler
approved these changes
Jun 30, 2023
|
@swift-ci Please test macOS platform |
|
@swift-ci Please test and merge |
|
@swift-ci Please test macOS platform |
|
@swift-ci Please test |
natecook1000
added a commit
to natecook1000/swift
that referenced
this pull request
Jul 10, 2023
* Make ObservationRegistrar Codable/Hashable These conformances enable automatic Codable synthesis for Observable types, and smooth the runway for structs being supported by the Observable macro in the future. * Limit Observable macro to classes This removes the ability for the Observable macro to apply to structs, and adds diagnostic tests for the three disallowed declaration kinds.
natecook1000
added a commit
that referenced
this pull request
Jul 11, 2023
* Make the `@Observable` macro class only (#67033) * Make ObservationRegistrar Codable/Hashable These conformances enable automatic Codable synthesis for Observable types, and smooth the runway for structs being supported by the Observable macro in the future. * Limit Observable macro to classes This removes the ability for the Observable macro to apply to structs, and adds diagnostic tests for the three disallowed declaration kinds. * [Observation] Switch `Observable` to be a non-marker protocol (#66993) With support for redundant conformance declarations via macros, the `Observable` protocol can be a non-marker protocol, which provides more flexibility for evolution in the future. rdar://111463883 This change also switches to the new ExtensionMacro protocol, the requirement for which includes information about whether the conformance to the Observable protocol has already been added, either in the declaration or in a superclass to the macro-attributed type. This allows the @observable macro to be applied to subclasses of observable types without redundant-conformance errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the ability for the Observable macro to apply to structs, and adds diagnostic tests for the three disallowed declaration kinds. It also adds
CodableandHashableconformance to theObservationRegistrartype, in order to smooth the future direction of@Observablesupport for structs.