[5.9] AllocBoxToStack: Remove bodies of closure functions left unused after specialization. #67035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… specialization. We can't remove the functions at this point in case they might have other function passes enqueued to run on them, but we can at least remove the function contents that are now unnecessary. We need to do this in cases when move-only types are involved, since the semantics of the move checker rely on unescaped captures being promoted before the pass runs, and we leave behind invalid SIL in the unpromoted code. rdar://110675352
|
@swift-ci Please test |
tbkka
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: rdar://110675352
• Explanation: Removes a source of potential compiler crashes when noncopyable types are captured in nonescaping closures.
• Scope of Issue: Crash-on-valid.
• Origination: Noncopyable types feature work.
• Risk: Low. The patch deletes SIL that is unreachable from the rest of the program so should have no runtime effect.
• Reviewed By: @gottesmm
• Automated Testing: Swift CI
• Dependencies: None
• Builder Impact: Not applicable
• Directions for QE: None