Skip to content

[Sema] Record a fix about extra parens for computed properties #67042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2023
Merged

[Sema] Record a fix about extra parens for computed properties #67042

merged 1 commit into from
Jul 10, 2023

Conversation

simanerush
Copy link
Member

Fixes #66393.

@simanerush simanerush added the parameter packs Feature → generics: Parameter packs label Jun 30, 2023
@simanerush simanerush requested review from hborla and xedin as code owners June 30, 2023 01:39
@simanerush simanerush requested a review from AnthonyLatsis June 30, 2023 01:40
@simanerush simanerush changed the title [Constraint System] Record a fix about extra parens for computed properties [Sema] Record a fix about extra parens for computed properties Jun 30, 2023
xedin
xedin reviewed Jun 30, 2023
View reviewed changes
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the bug! I left one comment inline and please add a test-case from the related Github issue to test/Constraints/pack-expansion-expressions.swift

@simanerush simanerush force-pushed the simanerush/66393 branch 3 times, most recently from fac5ffe to 983cef2 Compare July 5, 2023 17:02
@simanerush
Copy link
Member Author

@xedin I added tests and improved the logic, could you take a look?

xedin
xedin approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! As a follow-up maybe, you could actually improve this check to account for presence of pack archetypes and produce a regular conversion mismatch to address all of the FIXMEs.

@xedin
Copy link
Contributor

xedin commented Jul 5, 2023

@swift-ci please test

AnthonyLatsis
AnthonyLatsis reviewed Jul 5, 2023
View reviewed changes
Record a fix about extra parens for computed properties
b1ebd5d 
Use countType and add an additional tuple check

Add tests

[Sema] Record a fix about extra parens for computed properties
@simanerush
Copy link
Member Author

@swift-ci please test

@xedin
Copy link
Contributor

xedin commented Jul 10, 2023

@swift-ci please smoke test

@simanerush simanerush merged commit 83a7e05 into swiftlang:main Jul 10, 2023
@simanerush simanerush deleted the simanerush/66393 branch July 10, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnthonyLatsis AnthonyLatsis AnthonyLatsis left review comments

@xedin xedin xedin approved these changes

@hborla hborla Awaiting requested review from hborla hborla is a code owner

Assignees
No one assigned
Labels
parameter packs Feature → generics: Parameter packs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve error about extra parens with parameter packs
3 participants
@simanerush @xedin @AnthonyLatsis