[Distributed][TestOnly] PoC using a property wrapper on distributed func param for validation #67043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
ktoso
changed the title
|
Let's run full suite before we merge to make sure that this works on iOS and other simulators. |
|
@swift-ci please test |
|
Yeah, gotta keep running full suites on distributed stuff I guess. Thank you for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test for how parameter property wrappers can be used to validate distributed func parameters.
Do note that we cannot throw in such position right now, so the only option for such validation would be to fatal error.
We could consider allowing throwing in such positions if it were really necessary perhaps.
rdar://111534426