[5.9][move-only] When adding implicit liveness uses for class field/global accesses, do not use the terminator, use the end access.

[gottesmm]

This PR contains two different, but related changes. I am going to CCC them together since the changes were both found while fixing the same test that I am uploading here.

---

• Description: [5.9][move-only] When adding implicit liveness uses for class field/global accesses, do not use the terminator, use the end access. The language impact is that we miscompile this type of code:

func assignableButNotConsumableEndAccessImplicitLifetimeTest(_ x: CopyableKlassWithMoveOnlyField) {
     if boolValue {
         x.moveOnlyVarStruct.nonTrivialStruct2 = NonTrivialStruct2()
     }
 }

In words, we miscompile a place where we conditionally apply an assign. The result is that we insert a destroy_addr on the value before we do the assign, causing us to destroy the original value before we do the actual assign.
• Risk: This is low risk since it only affects a corner case in a specific part of the noncopyable checker. So it cannot affect anything but noncopyable code.
• Original PR: #67088
• Reviewed By: @jckarter
• Testing: Added SIL/Swift/Interpreter tests to validate the behavior. (The interpreter test is moveonly_linkedlist.swift which I included in the last cherry-picked commit since the next commit is also needed for it).
• Resolves: rdar://111659649

---

• Description: [move-only] Fix a place in DI where we were not converting an assignable_but_not_consumable -> initable_but_not_consumable. I fixed this for assign but missed a place where we needed to do the same thing for copy_addr. The language impact of this change is that we miscompile initializations of generic types in certain specific cases like in moveonly_linkedlist.swift:12.
• Risk: This is low risk since it only affects a corner case in DefiniteInitialization that only applies to noncopyable code. So it cannot affect anything but noncopyable code.
• Original PR: #67088
• Reviewed By: @jckarter
• Testing: Added a SIL/Swift/Interpreter tests to validate the behavior. (The interpreter test is moveonly_linkedlist.swift)
• Resolves: rdar://111709236

[gottesmm]

@swift-ci test

[nate-chandler]

but after some recent changes to field sensitive pruned liveness, this seems to no longer work.

I tried the new @assignableButNotConsumableEndAccessImplicitLifetimeTest test case with the compiler before my recent changes to FieldSensitivePrunedLiveness (git checkout 606eef619f2d2bc6b22e1f625461cbfe779617ca + ./utils/update-checkout --scheme=main --match-timestamp) and see this verification failure

SIL verification failed: instruction isn't dominated by its operand: properlyDominates(valueI, I)
Verifying instruction:
     %7 = begin_access [modify] [dynamic] %6 : $*NonTrivialStruct // users: %10, %5, %8, %12
->   destroy_addr %7 : $*NonTrivialStruct         // id: %5
In function:
// assignableButNotConsumableEndAccessImplicitLifetimeTest

[gottesmm]

@nate-chandler Ok, I could be wrong. My assumption was that it was something related to maximizing lifetime or field sensitive pruned liveness. Regardless, this needs to be fixed.

[gottesmm]

@swift-ci test

[gottesmm]

As part of testing this, I discovered another issue in DI that is tied a little to this, so I am going to CCC them together.

[gottesmm]

@swift-ci test macOS platform