Skip to content

Revert "[interop] do not import functions whose return type is not imported" #67097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 5, 2023
Merged

Revert "[interop] do not import functions whose return type is not imported" #67097

merged 2 commits into from
Jul 5, 2023

Conversation

hyp
Copy link
Contributor

@hyp hyp commented Jul 3, 2023

additionally, [interop] ensure C++ stdlib set's insert methods are unsafe

@hyp hyp added the c++ interop Feature: Interoperability with C++ label Jul 3, 2023
@hyp hyp removed request for xedin, slavapestov and hborla July 3, 2023 20:45
@hyp
Copy link
Contributor Author

hyp commented Jul 3, 2023

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Jul 3, 2023

@swift-ci please test source compatibility

egorzhdan
egorzhdan approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@egorzhdan egorzhdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hyp hyp merged commit 0be01c4 into swiftlang:main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egorzhdan egorzhdan egorzhdan approved these changes

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver is a code owner

Assignees
No one assigned
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyp @egorzhdan