[Macros] Add missing macro validation. #67106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…covered by the macro declaration.
hborla
changed the title
hborla
force-pushed
the
validate-extension-macros
branch
from
fa11530 to
1756ee7
Compare
|
@swift-ci please smoke test |
hborla
force-pushed
the
validate-extension-macros
branch
from
1756ee7 to
04ea8b0
Compare
|
@swift-ci please smoke test |
DougGregor
approved these changes
Jul 14, 2023
| case MacroRole::Conformance: | ||
| case MacroRole::Extension: | ||
| // Only primary declarations of nominal types | ||
| if (isa<NominalTypeDecl>(attachedTo)) |
There was a problem hiding this comment.
I thought one would be allowed to put an extension macro on an extension?
There was a problem hiding this comment.
The only reason I banned extensions here is because I didn't implement it yet. This came up in the review thread too. It should be very straightforward to generalize the places that assume an extension macro is applied to a NominalTypeDecl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@attached(extension)attribute. Otherwise, the compiler emits an error that the generated name is not covered.importdeclaration.Resolves rdar://111685434