🍒[5.9][Distributed] Handle composite type in generic bound in distributed accessor #67118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ccessor rdar://111664985
ktoso
added
distributed
ktoso
commented
Jul 5, 2023
| @@ -616,6 +616,8 @@ void DistributedAccessor::emit() { | |||
|
|
|||
| auto params = IGF.collectParameters(); | |||
|
|
|||
| GenericContextScope scope(IGM, targetTy->getInvocationGenericSignature()); | |||
There was a problem hiding this comment.
The fix™ is that this must be made before the IGM getTypeInfo call, otherwise the generic context is not available (null) and we crash.
|
@swift-ci please test |
DougGregor
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: It seems a distributed accessor's emit fails for
DistributedActor & Somethign, the crash is inIGM.getTypeInfo(directResultTy);because the method does not have access to a generic context; The solution is to provide it earlier during emit rather than later as we did before.See Also: Resolves a FIXME in distributed cluster: https://github.com/apple/swift-distributed-actors/pull/1127/files#diff-7da4ba0dfda5902083a859fdf6d209fb5902d4926b6bee24fa7eee420b84b4e3R231
Risk: Low, only moves the generic scope a few lines earlier, since we use it there already
Reviewed by: @xedin @drexin (original PR)
Original PR: #67117
Testing: CI testing
Radar: rdar://111664985
Resolves: #67090