🍒[cxx-interop] Import OS_OBJECT_DECL consistently with and without C++ interop enabled
#67125
+19
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…++ interop enabled Previously ClangImporter was not able to lookup `NSObject` when C++ interop is enabled, which caused types such as `xpc_object_t` from system module XPC to be imported differently: `any OS_xpc_object` without C++ interop vs `any NSObject & OS_xpc_object` with C++ interop enabled. rdar://110000787 (cherry picked from commit 5a62032)
|
@swift-ci please test |
DougGregor
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: ClangImporter was not able to lookup
NSObjectwhen C++ interop is enabled, which caused types such asxpc_object_tfrom system module XPC to be imported differently:any OS_xpc_objectwithout C++ interop vsany NSObject & OS_xpc_objectwith C++ interop enabled.Scope: This alters the way
NSObjecttype is looked up by ClangImporter.Risk: Medium, this alters the code path that can be taken without having C++ interop enabled.
Original PR: #67116
rdar://110000787
(cherry picked from commit 5a62032)