Skip to content

[DependencyScan] Fix and cleanup CAS Depscanner #67133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2023
Merged

[DependencyScan] Fix and cleanup CAS Depscanner #67133

merged 2 commits into from
Jul 11, 2023

Conversation

cachemeifyoucan
Copy link
Contributor

Fix and cleanup dependency scanner for CAS.

@cachemeifyoucan
Copy link
Contributor Author

@artemcm Can you double check if my assumption in the last commit is correct? Currently, swift-driver will gets more and more command-line arguments as it tries to rescan the dependency.

artemcm
artemcm reviewed Jul 5, 2023
View reviewed changes
@artemcm
Copy link
Contributor

artemcm commented Jul 5, 2023

@artemcm Can you double check if my assumption in the last commit is correct? Currently, swift-driver will gets more and more command-line arguments as it tries to rescan the dependency.

Yeah, makes sense to me, good catch!

benlangmuir
benlangmuir reviewed Jul 5, 2023
View reviewed changes
@cachemeifyoucan cachemeifyoucan force-pushed the eng/PR-cas-deps-fixups branch from fcbf14f to 101adee Compare July 5, 2023 21:53
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please smoke test

@cachemeifyoucan cachemeifyoucan force-pushed the eng/PR-cas-deps-fixups branch from 101adee to 6e55a75 Compare July 6, 2023 16:16
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please smoke test

@cachemeifyoucan cachemeifyoucan force-pushed the eng/PR-cas-deps-fixups branch from 6e55a75 to 12e227f Compare July 6, 2023 18:22
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please smoke test

@cachemeifyoucan cachemeifyoucan force-pushed the eng/PR-cas-deps-fixups branch from 12e227f to 0a71082 Compare July 6, 2023 21:21
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please smoke test

@cachemeifyoucan cachemeifyoucan force-pushed the eng/PR-cas-deps-fixups branch from 0a71082 to a5081ad Compare July 7, 2023 00:02
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please smoke test

@cachemeifyoucan cachemeifyoucan force-pushed the eng/PR-cas-deps-fixups branch from a5081ad to d9bbc93 Compare July 7, 2023 23:57
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please smoke test

@xedin xedin removed their request for review July 10, 2023 17:06
@cachemeifyoucan cachemeifyoucan force-pushed the eng/PR-cas-deps-fixups branch from d9bbc93 to ad34ae6 Compare July 10, 2023 18:50
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please clean smoke test

@cachemeifyoucan cachemeifyoucan force-pushed the eng/PR-cas-deps-fixups branch from ad34ae6 to 4276fc1 Compare July 10, 2023 22:41
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please smoke test

@cachemeifyoucan
[CAS][DependencyScan] Add bridging header inputs into mainModule CAS …
7fd951b 
…deps

Make sure the sources for bridging header is added as part of the CAS
filesystem for the main module. Even bridging header should be compiled
into PCH, PCHs are not standalone that it can be used without source
file.
@cachemeifyoucan
[NFC][CAS] Cleanup CAS-based file system initialization
96e0965
@cachemeifyoucan cachemeifyoucan force-pushed the eng/PR-cas-deps-fixups branch from 4276fc1 to 96e0965 Compare July 11, 2023 15:51
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please smoke test

@cachemeifyoucan
Copy link
Contributor Author

Drop out the part that finalize the command-line to avoid multiple argument append since that seems to break test cases nondeterministically.

It is very small fix now. Merging.

@cachemeifyoucan cachemeifyoucan merged commit 06d7403 into swiftlang:main Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemcm artemcm artemcm left review comments

@benlangmuir benlangmuir benlangmuir approved these changes

@akyrtzi akyrtzi Awaiting requested review from akyrtzi

@zoecarver zoecarver Awaiting requested review from zoecarver

@hyp hyp Awaiting requested review from hyp

@egorzhdan egorzhdan Awaiting requested review from egorzhdan

@hborla hborla Awaiting requested review from hborla

@slavapestov slavapestov Awaiting requested review from slavapestov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cachemeifyoucan @artemcm @benlangmuir