Skip to content

stdlib/cmake: add missing macro definitions required for WASI #67139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 6, 2023

Conversation

MaxDesiatov
Copy link
Contributor

We need -D_WASI_EMULATED_SIGNAL passed when building for WASI to fully support it.

We need `-D_WASI_EMULATED_SIGNAL` passed when building for WASI to fully support it.
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov
Copy link
Contributor Author

preset=buildbot_incremental_linux_crosscompile_wasm
@swift-ci Please test with preset Linux Platform

@MaxDesiatov
Copy link
Contributor Author

@swift-ci build toolchain

@MaxDesiatov MaxDesiatov added the standard library Area: Standard library umbrella label Jul 5, 2023
@kateinoigakukun
Copy link
Member

kateinoigakukun commented Jul 6, 2023

Let me check if it's actually necessary change :)

@kateinoigakukun
Copy link
Member

OK, I've confirmed only the changes in stdlib/cmake/modules/AddSwiftStdlib.cmake is necessary to build stdlib

@MaxDesiatov
Copy link
Contributor Author

@swift-ci smoke test

@MaxDesiatov MaxDesiatov merged commit 0d1eca1 into main Jul 6, 2023
@MaxDesiatov MaxDesiatov deleted the maxd/wasi-emulated-signal branch July 6, 2023 14:51
@MaxDesiatov MaxDesiatov added the WebAssembly Platform: WebAssembly label Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
standard library Area: Standard library umbrella WebAssembly Platform: WebAssembly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants