Skip to content

test: add missing import WASILibc to cancellation_handler.swift #67143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2023
Merged

test: add missing import WASILibc to cancellation_handler.swift #67143

merged 1 commit into from
Jul 6, 2023

Conversation

MaxDesiatov
Copy link
Contributor

This allows this test to build and run when targeting WASI.

@MaxDesiatov
test: add missing import WASILibc to cancellation_handler.swift
38fbcf6 
This allows this test to build and run when targeting WASI.
@MaxDesiatov MaxDesiatov added test suite Area: test suite Concurrencу Area → standard library: The `Concurrency` module under the standard library umbrella labels Jul 5, 2023
@MaxDesiatov MaxDesiatov requested review from ktoso and kavon as code owners July 5, 2023 23:11
@MaxDesiatov
Copy link
Contributor Author

preset=buildbot_incremental_linux_crosscompile_wasm
@swift-ci Please test with preset Linux Platform

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov
Copy link
Contributor Author

@swift-ci build toolchain

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test windows

1 similar comment
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test windows

@MaxDesiatov MaxDesiatov merged commit 8c2dffd into main Jul 6, 2023
@MaxDesiatov MaxDesiatov deleted the maxd/fix-cancellation-handler branch July 6, 2023 09:15
@MaxDesiatov MaxDesiatov added the WebAssembly Platform: WebAssembly label Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kateinoigakukun kateinoigakukun kateinoigakukun approved these changes

@ktoso ktoso Awaiting requested review from ktoso ktoso is a code owner

@kavon kavon Awaiting requested review from kavon

Assignees
No one assigned
Labels
Concurrencу Area → standard library: The `Concurrency` module under the standard library umbrella test suite Area: test suite WebAssembly Platform: WebAssembly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxDesiatov @kateinoigakukun