Accessor macros finishing touches #67148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ready exists We used to crash; now we diagnose and... don't crash. Fixes rdar://111588129.
…property has one If an accessor macro is placed on a computed property, then opts not to produce a getter/setter, we would produce an error because the macro didn't make the computed property... computed. Fix that; it's already computed, and it's fine not to add accessors. Fixes rdar://111586568.
As with the initial value of a property that is converted from a stored property to a computed property by an accessor macro, remove didSet/willSet. It is the macro's responsibility to incorporate their code or diagnose them. Fixes rdar://111101833.
DougGregor
requested review from
hborla,
slavapestov,
xedin,
ahoppen,
bnbarham,
CodaFi and
rintaro
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please clean test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve accessor macros in several different related ways:
didSet/willSetwhen an accessor macro converts a stored property into a computed one; the macro itself takes responsibility for them.Fixes rdar://111588129&111586568&111101833