[AutoDiff] Prevent crash when using @differentiable without importing _Differentiation #67162
Conversation
|
@BradLarson could you invoke the CI bot for me? |
|
@swift-ci please test |
BradLarson
changed the title
| // **NOTE** - This test can likely be removed when/if the differentiation module is | ||
| // available by default in the Swift stdlib. | ||
| public func req() {} | ||
| } |
There was a problem hiding this comment.
Should we end with a newline here like most other tests?
| } | |
| } | |
| // **NOTE** - This test can likely be removed when/if the differentiation module is | ||
| // available by default in the Swift stdlib. |
There was a problem hiding this comment.
The likelihood of this may be 0 though, as domain-specific stdlibs tend to be standalone modules, like Distributed. Not sure it's worth mentioning.
There was a problem hiding this comment.
Good to know. I'll remove the comment.
lib/Sema/TypeCheckAttr.cpp
Outdated
| @@ -5789,7 +5789,8 @@ IndexSubset *DifferentiableAttributeTypeCheckRequest::evaluate( | |||
| void AttributeChecker::visitDifferentiableAttr(DifferentiableAttr *attr) { | |||
| // Call `getParameterIndices` to trigger | |||
| // `DifferentiableAttributeTypeCheckRequest`. | |||
| (void)attr->getParameterIndices(); | |||
| if (attr->getParameterIndices() == nullptr) | |||
| attr->setInvalid(); | |||
There was a problem hiding this comment.
Instead, should DifferentiableAttributeTypeCheckRequest be responsible for setting the attr as invalid? The request is already doing so in some places when it calls typecheckDifferentiableAttrforDecl.
There was a problem hiding this comment.
Sure. I'll make the change.
The above referenced issue was causing a compiler crash when writing differentiable protocols and corresponding implementers, without importing the `_Differentiation` module. Changes in this CR fix the issue by marking any `@differentiable` attributes as invalid, if the `_Differentiation` module has not been imported. This ignores the `@differentiable` attributes when the protocol witnesses are being verified. Witness verification was previously leading to an error (due to missing `@differentiable` attribute on the protocol requirement implementer), and the corresponding diagnostic emission code was then leading to a crash, because it was expecting the `_Differentiation` module to be present.
|
@swift-ci please test |
The above referenced issue was causing a compiler crash when writing differentiable protocols and corresponding implementers, without importing the
_Differentiationmodule.Changes in this CR fix the issue by marking any
@differentiableattributes as invalid, if the_Differentiationmodule has not been imported. This ignores the@differentiableattributes when the protocol witnesses are being verified. Witness verification was previously leading to an error (due to missing@differentiableattribute on the protocol requirement implementer), and the corresponding diagnostic emission code was then leading to a crash, because it was expecting the_Differentiationmodule to be present.Fixes #59100