add tracking of pack environments for pack elements to Constraint System #67164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophiapoirier
force-pushed
the
pack-environments-for-elements
branch
from
92e6608 to
7588aae
Compare
xedin
approved these changes
Jul 6, 2023
| packType = CS.getType(elementExpr->getPackRefExpr()); | ||
| } else if (auto *elementType = getAsTypeRepr<PackElementTypeRepr>(pack)) { | ||
| if (isExpr<PackElementExpr>(pack)) { | ||
| continue; |
There was a problem hiding this comment.
Nit: Could you please leave a comment here explaining why we skip over pack elements and where the connection between this pack expansion and pack element is established now to make it easier in the future to figure out what is going on here?
sophiapoirier
force-pushed
the
pack-environments-for-elements
branch
from
b6d98a3 to
d3000fa
Compare
…ts to Constraint System
sophiapoirier
force-pushed
the
pack-environments-for-elements
branch
from
c8908f9 to
63e30b5
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor is a prerequisite to my next PR that will address an abstract tuple bug.