[Parse] Accept 'self' after 'each' #67206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also move 'repeat', 'each', and 'any' expression parsing to 'parseExprSequenceElement' rdar://107450487
rintaro
requested review from
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hborla,
slavapestov and
xedin
as code owners
|
swiftlang/swift-syntax#1895 |
|
swiftlang/swift-syntax#1895 |
ahoppen
reviewed
Jul 11, 2023
Comment on lines
+478
to
+489
| if (Tok.is(tok::kw_repeat)) { | ||
| SourceLoc repeatLoc = consumeToken(); | ||
| auto patternExpr = parseExprImpl( | ||
| diag::expected_expr_after_repeat, isExprBasic); | ||
| if (patternExpr.isNull()) | ||
| return patternExpr; | ||
|
|
||
| auto *expansion = | ||
| PackExpansionExpr::create(Context, repeatLoc, patternExpr.get(), | ||
| /*genericEnv*/ nullptr); | ||
| return makeParserResult(expansion); | ||
| } |
There was a problem hiding this comment.
The same comment that I left on https://github.com/apple/swift-syntax/pull/1895/files#r1259240007
I just noticed that we already never parse
repeatas a function call in the following (not a regression introduced by this PR, this just made me realize it…func repeat() {} repeat()
ahoppen
approved these changes
Jul 11, 2023
|
swiftlang/swift-syntax#1895 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also move 'repeat', 'each', and 'any' expression parsing to 'parseExprSequenceElement'
rdar://107450487