Skip to content

[5.9][Features] Allow ExtensionMacros to be enabled in noasserts builds. #67223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

hborla
Copy link
Member

@hborla hborla commented Jul 11, 2023

  • Explanation: The @Observable macro has adopted -enable-experimental-feature ExtensionMacros. The Observation module is built in noasserts configurations in CI, but this flag is not available in noasserts builds, hence breaking CI. This change allows the flag to be enabled in noasserts builds.
  • Scope: Only impacts the enable-experimental-feature ExtensionMacros feature flag.
  • Risk: Extremely low due to tiny scope.
  • Testing: noasserts CI configurations have successfully gotten past building the Observation module after the main PR was merged:
  • Main branch PR: [Features] Allow ExtensionMacros to be enabled in noasserts builds. #67208

@hborla hborla requested a review from a team as a code owner July 11, 2023 17:35
@hborla
Copy link
Member Author

hborla commented Jul 11, 2023

@swift-ci please test

@hborla hborla merged commit 27f4369 into swiftlang:release/5.9 Jul 12, 2023
@hborla hborla deleted the 5.9-extension-macro-flag branch July 12, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants