[RemoteMirror] Correctly project enums with zero-sized payloads #67257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I earlier overhauled the enum layout logic to correctly consider enums with generic cases and cases that have zero size. This updates the enum projection logic to use that information as well. In particular, this fixes a bug where an MPE with zero-sized cases would be incorrectly projected by RemoteMirror (with consequences for the `leaks` tool and lldb). Resolves rdar://111705059
|
@swift-ci Please test |
mikeash
approved these changes
Jul 12, 2023
tbkka
deleted the
tbkka-rdar111705059-project-MPE-with-zero-sized-payloads
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I earlier overhauled the enum layout logic to correctly consider enums with generic cases and cases that have zero size. This updates the enum projection logic to use that information as well.
In particular, this fixes a bug where an MPE with zero-sized cases would be incorrectly projected by RemoteMirror (with consequences for the
leakstool and lldb).Resolves rdar://111705059