[ExplicitModule] Allow typecheck-module-from-interface using explicit module #67263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachemeifyoucan
requested review from
artemcm,
tshortli,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
cachemeifyoucan
force-pushed
the
eng/PR-explicit-module-interface-check
branch
from
555ee9b to
5509fed
Compare
|
@swift-ci please smoke test |
cachemeifyoucan
force-pushed
the
eng/PR-explicit-module-interface-check
branch
from
5509fed to
0369141
Compare
… module Allow `-typecheck-module-from-interface` using explicit module instead of building implicit module. This setups swift-frontend to accept explicit module build arguments and loading explicit module during verifying. SwiftDriver needs to setup correct arguments including the output path for swift module to fully enable explicit module interface check.
-typecheck-module-from-interface doesn't emit textual output as configured in frontend option. The real output is diagnostics but that is not tracked by output computer which is using the option. Teach `swift-frontend` that it doesn't actually emit any real output and tell serialization not to emit swiftmodule.
cachemeifyoucan
force-pushed
the
eng/PR-explicit-module-interface-check
branch
from
0369141 to
411937d
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test linux platform |
|
ping |
artemcm
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
-typecheck-module-from-interfaceusing explicit module instead of building implicit module.This setups swift-frontend to accept explicit module build arguments and loading explicit module during verifying. SwiftDriver needs to setup correct arguments including the output path for swift module to fully enable explicit module interface check.