Skip to content

[SymbolGraphGen] allow cursor symbol graphs from function params #67267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 13, 2023
Merged

[SymbolGraphGen] allow cursor symbol graphs from function params #67267

merged 3 commits into from
Jul 13, 2023

Conversation

QuietMisdreavus
Copy link
Contributor

Resolves rdar://105516823

When SourceKit requests a symbol graph for a function or closure parameter, SymbolGraphGen currently doesn't report anything, as ParamDecls are unsupported. This PR adds support for ParamDecl by treating it as a VarDecl.

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please smoke test

@QuietMisdreavus QuietMisdreavus mentioned this pull request Jul 12, 2023
Merged
@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please smoke test

@bnbarham
Copy link
Contributor

URI still has a / in rather than \\. FWIW in general I think it'd be better to reduce the check as much as possible, all we really care about is variable name + type. The rest are just checks we'll have to fix if up the output of the symbol graph ever changes 😅

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please smoke test

@QuietMisdreavus QuietMisdreavus merged commit 2565925 into main Jul 13, 2023
@QuietMisdreavus QuietMisdreavus deleted the QuietMisdreavus/param-sgf branch July 13, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rintaro rintaro rintaro approved these changes

@bnbarham bnbarham bnbarham approved these changes

@ahoppen ahoppen Awaiting requested review from ahoppen

@hamishknight hamishknight Awaiting requested review from hamishknight hamishknight is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QuietMisdreavus @bnbarham @rintaro