Skip to content

[5.9] ModuleLoader: emit a note when encountering a blocklisted module interface #67273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2023
Merged

[5.9] ModuleLoader: emit a note when encountering a blocklisted module interface #67273

merged 1 commit into from
Jul 13, 2023

Conversation

nkcsgexi
Copy link
Contributor

@nkcsgexi nkcsgexi commented Jul 12, 2023 •
edited
Loading

  • Explanation: separately installed blocklist can inform the compiler about downgrading the module interface verification errors to warnings to unblock the build. When this happens, a note should be emitted in the build log so engineers can be better informed of that such behavior is intentional.
  • Scope: module interface verification
  • Risk: Extremely low
  • Testing: Regression test added
  • Main branch PR: ModuleLoader: emit a note when encountering a blocklisted module interface #67269

@nkcsgexi nkcsgexi requested a review from a team as a code owner July 12, 2023 22:20
@nkcsgexi
Copy link
Contributor Author

@swift-ci please test

@nkcsgexi nkcsgexi merged commit 5437959 into release/5.9 Jul 13, 2023
@nkcsgexi nkcsgexi deleted the block-list-note-5.9 branch July 13, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkcsgexi @bnbarham