[ConstraintSystem] implement implicit pack materialization for abstract tuples instead of explicit '.element' #67292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophiapoirier
requested review from
hborla,
xedin and
slavapestov
as code owners
…ct tuples instead of explicit '.element'
sophiapoirier
force-pushed
the
pack-stored-propety-shadows-global
branch
from
2b124cd to
fa41015
Compare
sophiapoirier
changed the title
|
@swift-ci please test |
xedin
approved these changes
Jul 14, 2023
| emitDiagnostic(diag::pack_reference_outside_expansion, | ||
| packType); | ||
| auto patternType = | ||
| getPatternTypeOfSingleUnlabeledPackExpansionTuple(packType); |
There was a problem hiding this comment.
One note because I'll forget and it could totally be done separately - both InvalidPackReference and InvalidPackElement constructors should use resolveType(packType) and resolveType(packElementType) accordingly instead of just packType and packElementType, otherwise we'd end up with a diagnostic that could have type variables in it and crash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.