[5.9][IRGen] Visit members generated by peer macros in ClassDataBuilder. #67315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by calling getAllMembers() instead of getMembers() in TypeMemberVisitor::visitImplementationMembers. (cherry picked from commit d3c67ef)
|
@swift-ci please test |
bnbarham
approved these changes
Jul 14, 2023
in evaluateMembersRequest. (cherry picked from commit 58ad17a)
|
@swift-ci please test |
explicitly. (cherry picked from commit b746a03)
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClassDataBuilderwas skipping members generated by peer macros becauseTypeMemberVisitor::visitImplementationMemberscalledgetMembers()instead ofgetAllMembers(). This prevents@Observablefrom switching to peer macros that generate prefixed names instead of a member macro that generatesarbitrarynames.getMembers()such as peer macros.getMembers()andgetAllMembers()is the latter includes synthesized and macro-generated members.