[cxx-interop] Import mutating dereference operators #67375
Merged
+213
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egorzhdan
force-pushed
the
egorzhdan/mutable-var-pointee
branch
from
56cc467 to
01ecb45
Compare
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/mutable-var-pointee
branch
from
01ecb45 to
6c81fca
Compare
|
@swift-ci please smoke test |
C++ `T& operator*()` is mapped to a Swift computed property `var pointee: T`. Previously `var pointee` only had a getter, after this change it will also have a setter if the C++ type declares an overload of `operator*` that returns a mutable reference. rdar://112471779
egorzhdan
force-pushed
the
egorzhdan/mutable-var-pointee
branch
from
6c81fca to
8832d27
Compare
|
@swift-ci please smoke test |
|
If this is not going to 5.9 this needs to be gated by a versioning scheme to prevent source breakages presumably |
|
@hyp I couldn't come up with a case where this would cause source breakages, could you give an example? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C++
T& operator*()is mapped to a Swift computed propertyvar pointee: T.Previously
var pointeeonly had a getter, after this change it will also have a setter if the C++ type declares an overload ofoperator*that returns a mutable reference.rdar://112471779