Skip to content

Fix RawSILInstLowering for InitAccessors #67379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

atrick
Copy link
Contributor

@atrick atrick commented Jul 18, 2023

If 'self' is already borrowed, then avoid creating a redundant end_borrow.

Fixes rdar://112417250 (Crash with macro expansion on generic NSObject subclass)

If 'self' is already borrowed, then avoid creating a redundant end_borrow.

Fixes rdar://112417250 (Crash with macro expansion on generic NSObject subclass)
@atrick atrick requested a review from xedin July 18, 2023 23:34
@atrick
Copy link
Contributor Author

atrick commented Jul 18, 2023

@swift-ci test

@xedin
Copy link
Contributor

xedin commented Jul 19, 2023

@atrick Thanks for the fix! I actually found and fixed it in my other PR that is waiting review - #67294

@atrick
Copy link
Contributor Author

atrick commented Jul 19, 2023

This will be covered by Pavel's PR

@atrick atrick closed this Jul 19, 2023
@atrick atrick deleted the fix-init-accessor-borrow branch September 19, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants