[AddressLowering] End borrow scopes for extracts/destructures at enclosing guaranteed boundary. #67384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nate-chandler
force-pushed
the
opaque-values/20230718/1/emit_end_borrows/destructure_and_extract
branch
from
4e94109 to
0fccca9
Compare
|
@swift-ci please test |
nate-chandler
force-pushed
the
opaque-values/20230718/1/emit_end_borrows/destructure_and_extract
branch
from
0fccca9 to
a7f99f7
Compare
|
@swift-ci please test |
meg-gupta
reviewed
Jul 19, 2023
nate-chandler
force-pushed
the
opaque-values/20230718/1/emit_end_borrows/destructure_and_extract
branch
from
a7f99f7 to
7ca5f6e
Compare
|
LGTM |
atrick
reviewed
Jul 19, 2023
A destructure may have users that have escaping operand ownership. Consequently, we can't rely on findInnerTransitiveGuaranteedUses as used by emitEndBorrows.
An extract may have users that have escaping operand ownership. Consequently, we can't rely on findInnerTransitiveGuaranteedUses as used by emitEndBorrows.
nate-chandler
force-pushed
the
opaque-values/20230718/1/emit_end_borrows/destructure_and_extract
branch
from
7ca5f6e to
4c5ce62
Compare
|
@swift-ci please test |
nate-chandler
deleted the
opaque-values/20230718/1/emit_end_borrows/destructure_and_extract
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
load_borrows created when lowering destructure and extract instructions may have users that have escaping operand ownership. Consequently, we can't rely onfindInnerTransitiveGuaranteedUsesas used byemitEndBorrows.In fact, this is generally true, so the
emitEndBorrowsfunction needs to be eliminated. This is the first step in that process.