swift-inspect: ensure that we eject any injected code #67396
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would previously fail to eject the injected code on a failure. This would prevent a future introspection into the process as well as leave the file open with an incremented retain count in the kernel space which would prevent the file from being deleted.
In the future, when the application is able to treat the injected code as a resource, this resource would be temporarily extracted, but would no longer be possible to delete until a reboot (with a registration of the deletion) due to the retained code.