[AddressLowering] End borrow scopes for begin_apply at coro endpoints. #67397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a `load_borrow` is created on behalf of a `begin_apply`, it's possible that it may have escaping users. When it does, `findInnerTransitiveGuaranteedUses` returns `false` and the uses it finds are incomplete. As a result the boundary computed in `emitEndBorrows` will be incomplete.
|
@swift-ci please test |
nate-chandler
deleted the
opaque-values/20230719/1/emit_end_borrows/begin_apply
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
load_borrowis created on behalf of abegin_apply, it's possible that it may have escaping users. When it does,findInnerTransitiveGuaranteedUsesreturnsfalseand the uses it finds are incomplete. As a result the boundary computed inemitEndBorrowswill be incomplete.In fact, this is generally true, so the
emitEndBorrowsfunction needs to be eliminated. This is the second step in that process.