-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Add support in the diagnostic verifier for verifying no fix-its #674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'd prefer something more explicit than |
The text "expected-no-fix-its" is the most explicit way I can think of, but it has the disadvantage of looking like a top-level expected diagnostic instead of a modifier to the previous expected diagnostic. Or make it part of the diagnoses kind, e.g. "expected-warning-no-fix-its"? As I think of various other possibilities I still like "{{}}". It's in the position of a fix-it, it looks like a fix-it, but it's empty. I think syntactically, it's closest to the intended semantics. That being said, I'm happy to change to whatever syntax. |
:-/ I see why you went with
Hm. I don't like any of these. |
{{none}} seems servicable to me. |
17576bf
to
3f0c46b
Compare
Alrighty. Switched to {{none}}, committed, squashed. |
Other than the one comment issue, this looks good to me! |
3f0c46b
to
967124f
Compare
Oops! Yep, fixed that. |
Checked what it would look like to verify fix-its in every case, and currently the tests are missing expected fix-its in 435 diagnoses in 60 test files. So as an alternative, added support for a no fix-its marker “{{none}}”, and added that marker to the c-style for deprecation tests where it applies.
967124f
to
db44bf7
Compare
(Fixed conflicts with another commit adding warnings for use of ++ to the tests, repushed.) |
Add support in the diagnostic verifier for verifying no fix-its.
Thanks, Greg! |
[Stress tester XFails] Update XFails
Checked what it would look like to verify fix-its in every case, and
currently the tests are missing expected fix-its in 435 diagnoses in 60
test files.
So as an alternative, added support for a no fix-its marker “{{}}”, and
added that marker to the c-style for deprecation tests where it applies.
See conversation in #552 for the motivation for this change.