[Observation] Forward availability and defines to extensions #67412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phausler
commented
Jul 19, 2023
| } | ||
|
|
||
| extension DeclGroupSyntax { | ||
| var availability: AttributeListSyntax? { |
There was a problem hiding this comment.
@DougGregor this seems really complex to forward things - should this be included in SwiftSyntax/macros directly?
There was a problem hiding this comment.
Perhaps. We'd need to clarify what exactly should be automatically transferred to the extensions and implement that in SwiftSyntax.
phausler
requested review from
DougGregor,
natecook1000,
stephentyrone and
hborla
|
@swift-ci please test |
phausler
force-pushed
the
pr/observation_availability
branch
from
b42a3aa to
cc1b386
Compare
|
@swift-ci please test |
DougGregor
reviewed
Jul 21, 2023
|
@swift-ci please test |
|
Windows failure seems unrelated. |
|
@swift-ci please test windows |
DougGregor
approved these changes
Jul 25, 2023
| } | ||
|
|
||
| extension DeclGroupSyntax { | ||
| var availability: AttributeListSyntax? { |
There was a problem hiding this comment.
Perhaps. We'd need to clarify what exactly should be automatically transferred to the extensions and implement that in SwiftSyntax.
phausler
added a commit
to phausler/swift
that referenced
this pull request
Jul 26, 2023
…ng#67412) * [Observation] Forward availability and defines to extensions * Simplify availability slightly from review feedback * Simplify availability for extensions to use `.with`
phausler
added a commit
that referenced
this pull request
Jul 30, 2023
* [Observation] Forward availability and defines to extensions (#67412) * [Observation] Forward availability and defines to extensions * Simplify availability slightly from review feedback * Simplify availability for extensions to use `.with` * Use older name for detaching nodes * Force a newline for the trailing trivia of the replicated availability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using availability markers and
#ifguards for observable types incorrectly emit extensions that are inherently incompatible with extensions.This forwards the relevant availability to the extensions.
Resolves:
rdar://112413879