[AddressLowering] Exit range check for args early. #67423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When determining whether a copy_value is part of a copy->store pair, if the value being copied is guaranteed, it is checked whether the store is within the lifetime of all its guaranteed roots. If one of those guaranteed roots is a function argument, the store is certainly within the lifetime, so exit early.
|
@swift-ci please test |
nate-chandler
deleted the
opaque-values/20230719/2/all_stores_within_guaranteed_argument_lifetime
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When determining whether a
copy_valueis part of acopy->storepair, if the value being copied is guaranteed, it is checked whether the store is within the lifetime of all its guaranteed roots. If one of those guaranteed roots is a function argument, the store is certainly within the lifetime, so exit early.