Skip to content

[5.9][Macros] Remove the ExtensionMacros experimental feature flag. #67424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 20, 2023
Merged

[5.9][Macros] Remove the ExtensionMacros experimental feature flag. #67424

merged 3 commits into from
Jul 20, 2023

Conversation

hborla
Copy link
Member

@hborla hborla commented Jul 20, 2023

  • Explanation: This change removes the ExtensionMacros experimental feature identifier and diagnoses @attached(conformance) attributes as being replaced by @attached(extension, conformances: <#Protocol#>).
  • Scope: Only impacts extension/conformance macros.
  • Issue: rdar://112548321
  • Risk: Low.
  • Testing: Updating existing tests.
  • Reviewer: @DougGregor
  • Main branch PR: [Macros] Remove the ExtensionMacros experimental feature flag. #67405

@hborla hborla requested a review from a team as a code owner July 20, 2023 01:02
@hborla
Copy link
Member Author

hborla commented Jul 20, 2023

swiftlang/swift-syntax#1932

@swift-ci please test

@hborla hborla merged commit aae180e into swiftlang:release/5.9 Jul 20, 2023
@hborla hborla deleted the 5.9-enable-extension-macros branch July 20, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hborla @DougGregor