[5.9][Sema/SIL] InitAccessors: Support default initialization of init accessor properties #67437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SILGenFunction This is a preliminary step towards enabling default initialization of init accessor properties in user-defined initializers because this logic would have to be shared by multiple places during SILGen. (cherry picked from commit 75ac138)
Instead of taking a setter type, let's switch over to a more general `AccessorKind` which allows us to cover init accessors and simplify `emitApplySetterToBase`. (cherry picked from commit 5fd502b)
…eparate method New method is going to be used to emit default value initializations for user-defined constructors. (cherry picked from commit 1f87ee8)
…xpressions Similar to regular stored properties emit initialization expressions for properties with init accessors at constructor's prolog. (cherry picked from commit aa52e42)
…nitialization of stored properties Default expression associated with an init accessor property should always subsume that of any property listed in "initializes". (cherry picked from commit fd2a7d5)
…about init accessors If stored property is covered by one or more init accessor property, it's default initializable when at least one of the init accessor properties has default value. (cherry picked from commit 2bfbb43)
…inBorrowOperation returns back original value Calling `emitBeginBorrowOperation` on something which is `load_borrow` for example with guaranteed ownership doesn't produce `begin_borrow` instruction, so we need to be careful not to emit mismatched `end_borrow` in such cases. (cherry picked from commit 65cfb1c)
… with DI data structures DI cares only about stored fields of the current type but `SILModule::getFieldIndex` goes through all of the supertypes as well. (cherry picked from commit 52ac782)
…ass properties `super.init()` should fully initialize "super" which means that such properties are mutated via a setter. (cherry picked from commit c87daab)
(cherry picked from commit ff19286)
|
@swift-ci please test |
hborla
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #67294
Explanation:
Implements revision of the init accessor proposal where init accessor properties take over initialization of all properties in their initialization scope.
init()) about init accessors (even if a stored property doesn't have an initializer expression, the compiler needs to check whether init accessor property that handles it does).Scope: Init accessors with default values
Main Branch PRs: [Sema/SIL] InitAccessors: Support default initialization of init accessor properties #67294
Resolves: rdar://112417250
Risk: Low
Reviewed By: @hborla @jckarter
Testing: Added test-cases to the suite.
Resolves: rdar://112417250