Skip to content

[5.9] Skip new parser validation when skipping function bodies #67492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2023
Merged

[5.9] Skip new parser validation when skipping function bodies #67492

merged 1 commit into from
Jul 25, 2023

Conversation

bnbarham
Copy link
Contributor

  • Explanation: Skips new parser validation when skipping function bodies, which is enabled in various jobs from the driver (eg. when writing out the swiftmodule only). This is required as the new parser doesn't handle skipping function bodies today.
  • Scope: Only impacts assert builds
  • Risk: Low
  • Testing: Added new lit test
  • Reviewer: @ahoppen @hamishknight
  • Main branch PR: Skip new parser validation when skipping function bodies #67352

@bnbarham
Skip new parser validation when skipping function bodies
20160d7 
This would otherwise result in false positives, since if the old parser
skipping a body with errors would cause a verification failure.

Don't perform round trip validation either, since we'll presumbly still
hit parsing the full file when not skipping bodies - there's no point
running it twice.

Resolves rdar://111032175.

(cherry picked from commit 392f98c)
@bnbarham bnbarham requested a review from a team as a code owner July 24, 2023 21:06
@bnbarham
Copy link
Contributor Author

@swift-ci please test

@bnbarham bnbarham added swift 5.9 🍒 release cherry pick Flag: Release branch cherry picks labels Jul 24, 2023
@bnbarham bnbarham merged commit 9c3928c into swiftlang:release/5.9 Jul 25, 2023
@bnbarham bnbarham deleted the cherry-disable-new-validation-when-skipping branch July 26, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bnbarham @DougGregor