No more pipes
#67496
Merged
No more pipes
#67496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavon
requested review from
ahoppen,
bnbarham,
rintaro,
hamishknight,
AnthonyLatsis,
LucianoPAlmeida and
xedin
as code owners
|
@swift-ci please test |
|
last failure was due to the python linter not liking the order of imports |
|
@swift-ci please test and merge |
This solves deprecation warnings in build-script: ``` DeprecationWarning: 'pipes' is deprecated and slated for removal in Python 3.13 ``` This change assumes that the minimum version of Python3 is 3.3, which has `shlex.quote`. Since our build bots currently use 3.6 as their Python version, we can't yet use `shlex.join` to further simplify some of the code using quote.
|
turns out the linter test doesn't report all issues it found. |
|
@swift-ci smoke test and merge |
xedin
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eliminates
pipesin favor ofshlexin our python utilites.This solves deprecation warnings in build-script:
This change assumes that the minimum version
of Python3 is 3.3, which has
shlex.quote.Since our build bots currently use 3.6 as their
Python version, we can't yet use
shlex.jointo further simplify some of the code using
quote.