[Macros] Don't allow types to shadow freestanding macros. #67513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When performing name lookup for freestanding macros (e.g., after the `#`), don't allow types to shadow macros from imported libraries. Fixes rdar://110429368.
|
@swift-ci please smoke test |
bnbarham
reviewed
Jul 25, 2023
| struct stringify<T> { } | ||
|
|
||
| func testStringify(a: Int, b: Int) { | ||
| _ = #stringify(a + b) |
There was a problem hiding this comment.
What's the diagnostic now if there's a type but no macro? I assume just a "cannot find macro..."?
There was a problem hiding this comment.
Yes, the same as it was before, because everything that isn't a macro gets filtered out.
hborla
approved these changes
Jul 25, 2023
The former was effectively a copy of the latter.
The implementation was previously finding the wrong macro declaration, leading to incorrect results recorded as the expected results.
DougGregor
requested review from
ahoppen,
rintaro and
hamishknight
as code owners
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing name lookup for freestanding macros (e.g., after the
#), don't allow types to shadow macros from imported libraries.Fixes rdar://110429368.