noncopyable diagnostics fix to correct error message wording #67519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out if you write `_ = consume s` you get different enough SIL than `_ = s` that it fools the ad-hoc test for whether we've mark-must-check'd a closure capture, since the former will have a begin_access. There doesn't appear to be a simple way to reuse the existing information or checking routine for this that was used by the checker itself to flag this.
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out if you write
_ = consume syou get different enough SIL than_ = sthat it fools the ad-hoc test for whether we've mark-must-check'd a closure capture, since the former will have a begin_access. There doesn't appear to be a simple way to reuse the existing information or checking routine for this that was used by the checker itself to flag this.