Skip to content

[5.9][Macros] Suppress the conformance macro diagnostic in swiftinterfaces. #67525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hborla
Copy link
Member

@hborla hborla commented Jul 26, 2023

  • Explanation: Programmers cannot fix compiler errors in swiftinterfaces, so suppress the error for @attached(conformance) attributes if they appear in swiftinterfaces.
  • Scope: Only impacts @attached(conformance) attributes in swiftinterfaces. The compiler cannot produce new interfaces with this attribute, but existing swiftinterfaces containing this attribute will continue to build.
  • Risk: Very low.
  • Testing: Added a test that builds a swift module from a swiftinterface containing an @attached(conformance) macro declaration.
  • Issue: rdar://112867079
  • Reviewer: @tshortli
  • Main branch PR: [Macros] Suppress the conformance macro diagnostic in swiftinterfaces. #67524

@hborla hborla requested a review from a team as a code owner July 26, 2023 01:02
@hborla
Copy link
Member Author

hborla commented Jul 26, 2023

@swift-ci please test

@hborla hborla merged commit c56aa07 into swiftlang:release/5.9 Jul 26, 2023
@hborla hborla deleted the 5.9-suppress-conformance-macro-error branch July 26, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants