[cxx-interop] Add UnsafeCxxMutableInputIterator protocol
#67536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egorzhdan
requested review from
zoecarver,
hyp,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
|
This shouldn't be source breaking , correct? |
|
Yeap, this is purely additive, we're just adding a new protocol and auto-conforming some types to it |
This is an inheritor of the existing `UnsafeCxxInputIterator` protocol, with the only difference being the ability to mutate `var pointee` via a non-const `operator*()`. This is needed to support mutable subscripts for `std::map` via `CxxDictionary`. rdar://105399019
egorzhdan
force-pushed
the
egorzhdan/unsafe-cxx-mutable-input-iterator
branch
from
04adc26 to
8d7d0ef
Compare
|
@swift-ci please smoke test |
egorzhdan
changed the title
UnsafeMutableCxxInputIterator protocolUnsafeCxxMutableInputIterator protocol
|
@swift-ci please smoke test Linux |
1 similar comment
|
@swift-ci please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an inheritor of the existing
UnsafeCxxInputIteratorprotocol, with the only difference being the ability to mutatevar pointeevia a non-constoperator*().This is needed to support mutable subscripts for
std::mapviaCxxDictionary.rdar://105399019