Platform: improve module definitions for Windows #67553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specify the C++ standard required for these submodules. Although this has no practical implications, it is useful for isolating the features with different C++ standards.
Add the missing submodule for `iomanip` on Windows.
These headers are not meant to be publicly consumed, introduce a `_Private` module for internal use for the `std` module.
This adds the `xutility` module to strip that from the first modular inclusion of the header.
Add a couple of missing submodules to the modulemap. This is for completeness and to help with newer MSVCPRT releases.
These modules were deprecated and do not exist in the distribution, remove the commented out form.
This was detected as missing when trying to re-modularise MSVCPRT.
Add the missing `std._Private.xstddef`, `std._Private.yvals`, and `std._Private.yvals_core` modules. This repairs the use of `std.map` as a private member variable of a type with an explicit ctor.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework a number of items within the platform specific module definitions for corecrt and MSVCPRT. This was done to try to find a modularisation failure.