Sema: Avoid decoding unavailable enum elements in derived Codable conformances #67556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
requested review from
AnthonyLatsis,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please test |
|
This was discussed on the Evolution forums here: https://forums.swift.org/t/codable-synthesis-and-decoding-unavailable-values/64926 |
|
@swift-ci please test source compatibility |
…formances. The compiler derived implementations of `Codable` conformances for enums did not take enum element unavailability into account. This could result in unavailable values being instantiated at runtime, leading to a general violation of the invariant that unavailable code is unreachable at runtime. This problem is possible because synthesized code is not type checked; had the conformances been hand-written, they would have been rejected for referencing unavailable declarations inside of available declarations. This change specifically alters derivation for the following declarations: - `Decodable.init(from:)` - `Encodable.encode(to:)` - `CodingKey.init(stringValue:)` Resolves rdar://110098469
|
Source compatibility failures are a known issue: #67534 |
tshortli
force-pushed
the
derived-codable-conformance-unavailable-enum-element
branch
from
2a61f54 to
7996c5b
Compare
|
@swift-ci please smoke test |
tshortli
changed the title
|
@swift-ci please smoke test Linux |
tshortli
deleted the
derived-codable-conformance-unavailable-enum-element
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler derived implementations of
Codableconformances for enums did not take enum element unavailability into account. This could result in unavailable values being instantiated at runtime, leading to a general violation of the invariant that unavailable code is unreachable at runtime. This problem is possible because synthesized code is not type checked; had the conformances been hand-written, they would have been rejected for referencing unavailable declarations inside of available declarations.This change specifically alters derivation for the following declarations:
Decodable.init(from:)Encodable.encode(to:)CodingKey.init(stringValue:)Resolves rdar://110098469