Sema: Fix two problems in checkReferencedGenericParams() analysis #67566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't walk into the count type of a PackExpansionType, because when matching two PackExpansionTypes, the solver only introduces a shape constraint between the count types, which does not fix it to a concrete type. - Similarly, don't walk into type alias substitutions, because only the desugared type is considered by the constraint solver. This is mildly source breaking, in that before we let you declare generic functions that could not be called.
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
|
@swift-ci Please smoke test Linux |
|
@swift-ci Please smoke test Windows |
|
@swift-ci Please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't walk into the count type of a PackExpansionType, because when matching two PackExpansionTypes, the solver only introduces a shape constraint between the count types, which does not fix it to a concrete type.
Similarly, don't walk into type alias substitutions, because only the desugared type is considered by the constraint solver.
This is mildly source breaking, in that before we let you declare generic functions that could not be called.