-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[SIL] Add source formal type to checked_cast_br. #67583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nate-chandler
merged 2 commits into
swiftlang:main
from
nate-chandler:checked_cast_br/formal-source
Jul 28, 2023
Merged
[SIL] Add source formal type to checked_cast_br. #67583
nate-chandler
merged 2 commits into
swiftlang:main
from
nate-chandler:checked_cast_br/formal-source
Jul 28, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is necessary for opaque values where for casts that will newly start out as checked_cast_brs and be lowered to checked_cast_addr_brs, since the latter has the source formal type, IRGen relies on being able to access it, and there's no way in general to obtain the source formal type from the source lowered type.
@swift-ci please test |
@swift-ci please test source compatibility |
@swift-ci please benchmark |
@swift-ci Please Apple Silicon benchmark |
|
atrick
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My review was cursory, but it looks great! Thanks for updating a million tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is necessary for opaque values for casts that will newly start out as
checked_cast_br
s and be lowered tochecked_cast_addr_br
s, since the latter has the source formal type,IRGen
relies on being able to access it, and there's no way in general to obtain the source formal type from the source lowered type.