[5.9][SILGenConstructor] InitAccessors: Make sure that accessed fields are initialized before init accessors #67586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into a method This is a preliminary step in order to enable re-ordering of initializations when init accessors are involved. (cherry picked from commit 3bb81e3)
… initialized before init accessors Initializations for all of the fields accessed by init accessor should be emitted before init accessor property even if they are declared after it in the source order. Resolves: rdar://112984795 (cherry picked from commit f6017cc)
|
@swift-ci please test |
hborla
approved these changes
Jul 27, 2023
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #67585
--
Initializations for all of the fields accessed by init accessor
should be emitted before init accessor property even if they are
declared after it in the source order, otherwise a call to init accessor
would reference uninitialized memory which is diagnosed by DI.
Scope: Init accessors in situations when they appear before properties they access.
Main Branch PRs: [SILGenConstructor] InitAccessors: Make sure that accessed fields are initialized before init accessors #67585
Resolves: rdar://112984795
Risk: Low
Reviewed By: @hborla
Testing: Added test-cases to the suite.
Resolves: rdar://112984795