Skip to content

[cxx-interop] NFC, test, drop extern_c from a test module #67595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2023
Merged

[cxx-interop] NFC, test, drop extern_c from a test module #67595

merged 1 commit into from
Jul 28, 2023

Conversation

hyp
Copy link
Contributor

@hyp hyp commented Jul 28, 2023

Explanation:
A C++ interop test had incorrect extern_c attribute on a module.
Scope: C++ interop tests.
Risk: Low, test only change.
Testing: Unit tests.

@hyp hyp requested a review from a team as a code owner July 28, 2023 18:00
@hyp
Copy link
Contributor Author

hyp commented Jul 28, 2023

@swift-ci please test

ravikandhadai
ravikandhadai approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@ravikandhadai ravikandhadai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hyp hyp merged commit a372310 into swiftlang:release/5.9 Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravikandhadai ravikandhadai ravikandhadai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyp @ravikandhadai