-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[WIP] Implement dependent layouts for raw types #67611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8882543
to
8466c43
Compare
@swift-ci please build toolchain macOS |
jckarter
reviewed
Jul 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on! Some initial comments:
266213d
to
c7dd5c7
Compare
jckarter
reviewed
Jul 31, 2023
c7dd5c7
to
b5f5609
Compare
@swift-ci please test |
@swift-ci please build toolchain macOS |
Update raw_layout.swift Allow for concrete specializations of raw layout Make test platform agnostic
b5f5609
to
17fe75b
Compare
522fb82
to
7ab9dbd
Compare
@swift-ci please test |
Add test Update raw_layout.swift Update raw_layout.swift
7ab9dbd
to
f840191
Compare
@swift-ci please test |
@swift-ci please test |
1 similar comment
@swift-ci please test |
8cc1451
to
3153e26
Compare
@swift-ci please test |
more int32 zzz
3153e26
to
c20ab10
Compare
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows raw types to have dependent layouts and calls into a new runtime function to handle these cases. Raw types have some other compilation issues preventing the Interpreter test from running correctly (assuming I wrote it right).