Skip to content

[WIP] Implement dependent layouts for raw types #67611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 16, 2023

Conversation

Azoy
Copy link
Contributor

@Azoy Azoy commented Jul 30, 2023

This allows raw types to have dependent layouts and calls into a new runtime function to handle these cases. Raw types have some other compilation issues preventing the Interpreter test from running correctly (assuming I wrote it right).

@Azoy Azoy requested a review from jckarter July 30, 2023 00:06
@Azoy Azoy force-pushed the raw-types-are-cool! branch from 8882543 to 8466c43 Compare July 30, 2023 05:17
@Azoy
Copy link
Contributor Author

Azoy commented Jul 30, 2023

@swift-ci please build toolchain macOS

Copy link
Contributor

@jckarter jckarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on! Some initial comments:

@Azoy Azoy force-pushed the raw-types-are-cool! branch 2 times, most recently from 266213d to c7dd5c7 Compare July 31, 2023 18:02
@Azoy Azoy force-pushed the raw-types-are-cool! branch from c7dd5c7 to b5f5609 Compare July 31, 2023 22:06
@Azoy
Copy link
Contributor Author

Azoy commented Aug 1, 2023

@swift-ci please test

@Azoy
Copy link
Contributor Author

Azoy commented Aug 1, 2023

@swift-ci please build toolchain macOS

@Azoy Azoy marked this pull request as ready for review August 1, 2023 01:11
Update raw_layout.swift

Allow for concrete specializations of raw layout

Make test platform agnostic
@Azoy Azoy force-pushed the raw-types-are-cool! branch from b5f5609 to 17fe75b Compare August 2, 2023 20:58
@Azoy Azoy requested a review from tshortli as a code owner August 2, 2023 20:58
@Azoy Azoy force-pushed the raw-types-are-cool! branch 2 times, most recently from 522fb82 to 7ab9dbd Compare August 3, 2023 04:20
@Azoy Azoy requested a review from jckarter August 3, 2023 04:21
@Azoy
Copy link
Contributor Author

Azoy commented Aug 3, 2023

@swift-ci please test

Add test

Update raw_layout.swift

Update raw_layout.swift
@Azoy Azoy force-pushed the raw-types-are-cool! branch from 7ab9dbd to f840191 Compare August 3, 2023 16:30
@Azoy
Copy link
Contributor Author

Azoy commented Aug 3, 2023

@swift-ci please test

@Azoy
Copy link
Contributor Author

Azoy commented Aug 3, 2023

@swift-ci please test

1 similar comment
@Azoy
Copy link
Contributor Author

Azoy commented Aug 15, 2023

@swift-ci please test

@Azoy Azoy force-pushed the raw-types-are-cool! branch from 8cc1451 to 3153e26 Compare August 15, 2023 23:11
@Azoy
Copy link
Contributor Author

Azoy commented Aug 15, 2023

@swift-ci please test

@Azoy Azoy force-pushed the raw-types-are-cool! branch from 3153e26 to c20ab10 Compare August 16, 2023 02:50
@Azoy
Copy link
Contributor Author

Azoy commented Aug 16, 2023

@swift-ci please test

@Azoy Azoy merged commit 44198d1 into swiftlang:main Aug 16, 2023
@Azoy Azoy deleted the raw-types-are-cool! branch August 16, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants